raulcd commented on PR #13309:
URL: https://github.com/apache/arrow/pull/13309#issuecomment-1148407883

   > The `package_data` entry in `setup(..)` itself doesn't need to be changed?
   
   I don't think it's necessary, all the files I expect (data and src) are 
correctly included on the wheel when I extract them:
   ```
   ....
     inflating: pyarrow/_orc.pyx        
     inflating: pyarrow/_parquet.cpython-310-x86_64-linux-gnu.so  
     inflating: pyarrow/_parquet.pxd    
     inflating: pyarrow/_parquet.pyx    
     inflating: pyarrow/_parquet_encryption.pxd  
     inflating: pyarrow/_parquet_encryption.pyx  
     inflating: pyarrow/_plasma.pyx  
   ....
     inflating: pyarrow/includes/__init__.pxd  
     inflating: pyarrow/includes/common.pxd  
     inflating: pyarrow/includes/libarrow.pxd  
     inflating: pyarrow/includes/libarrow_cuda.pxd  
     inflating: pyarrow/includes/libarrow_dataset.pxd  
     inflating: pyarrow/includes/libarrow_dataset_parquet.pxd  
     inflating: pyarrow/includes/libarrow_feather.pxd  
     inflating: pyarrow/includes/libarrow_flight.pxd  
     inflating: pyarrow/includes/libarrow_fs.pxd  
     inflating: pyarrow/includes/libarrow_python.pxd  
     inflating: pyarrow/includes/libarrow_substrait.pxd  
     inflating: pyarrow/includes/libgandiva.pxd  
     inflating: pyarrow/includes/libplasma.pxd  
     inflating: pyarrow/parquet/__init__.py  
     inflating: pyarrow/parquet/encryption.py  
     inflating: pyarrow/tensorflow/plasma_op.cc 
     inflating: pyarrow/vendored/__init__.py  
     inflating: pyarrow/vendored/docscrape.py  
     inflating: pyarrow/vendored/version.py  
   ```
   I can change the `package_data` to reflect the `arrow.includes` package with 
this diff:
   ```
   -    package_data={'pyarrow': ['*.pxd', '*.pyx', 'includes/*.pxd']},
   +    package_data={'pyarrow': ['*.pxd', '*.pyx'],
   +                  'pyarrow.includes': ['*.pxd']},
   
   ```
   but the resulting wheel contains exactly the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to