lidavidm commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891128430
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -157,7 +157,8 @@ elseif(GRPC_VERSION EQUAL "1.34" OR GRPC_VERSION EQUAL
"1.35")
elseif(GRPC_VERSION EQUAL "1.36")
add_definitions(-DGRPC_USE_TLS_CHANNEL_CREDENTIALS_OPTIONS
-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
-elseif(GRPC_VERSION EQUAL "1.43")
+elseif((GRPC_VERSION EQUAL "1.43") OR (GRPC_VERSION EQUAL "1.46"))
Review Comment:
What happens is that if we use system gRPC, we compile the test program and
then assign a version of "1.43" regardless of the actual version; if we use
bundled gRPC, we derive the version number from versions.txt. So a system gRPC
1.45 would still get reported as "1.43", but since we bumped the bundled
version, we need to explicitly handle it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
