pitrou commented on code in PR #13218:
URL: https://github.com/apache/arrow/pull/13218#discussion_r891233109
##########
cpp/src/arrow/compute/exec/key_hash.h:
##########
@@ -45,8 +45,8 @@ class ARROW_EXPORT Hashing32 {
friend void TestBloomSmall(BloomFilterBuildStrategy, int64_t, int, bool,
bool);
public:
- static void HashMultiColumn(const std::vector<KeyColumnArray>& cols,
- KeyEncoder::KeyEncoderContext* ctx, uint32_t*
out_hash);
+ static void HashMultiColumn(const std::vector<KeyColumnArray>& cols,
LightContext* ctx,
+ uint32_t* out_hash);
Review Comment:
> Do we have a strong style preference here?
Hmm, I don't think so. If it's used for templating then I suppose the class
is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
