pitrou commented on code in PR #12706:
URL: https://github.com/apache/arrow/pull/12706#discussion_r891414532
##########
cpp/src/arrow/array/validate.cc:
##########
@@ -509,22 +510,23 @@ struct ValidateArrayImpl {
}
if (full_validation) {
- if (data.null_count != kUnknownNullCount) {
Review Comment:
I think we should still compute the null count only if needed by the checks,
so e.g.:
```c++
if (data.null_count != kUnknownNullCount || !nullable) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
