raulcd commented on code in PR #13327:
URL: https://github.com/apache/arrow/pull/13327#discussion_r892149876
##########
python/pyarrow/_compute.pyx:
##########
@@ -2047,6 +2047,60 @@ class RandomOptions(_RandomOptions):
self._set_options(length, initializer)
+cdef class _RankOptions(FunctionOptions):
+
+ _tiebreaker_map = {
+ "Min": CRankOptionsTiebreaker_MIN,
+ "Max": CRankOptionsTiebreaker_MAX,
+ "First": CRankOptionsTiebreaker_FIRST,
+ "Dense": CRankOptionsTiebreaker_DENSE,
+ }
+
+ def _set_options(self, sort_keys, null_placement, tiebreaker):
+ cdef vector[CSortKey] c_sort_keys
+ for name, order in sort_keys:
+ c_sort_keys.push_back(
+ CSortKey(tobytes(name), unwrap_sort_order(order))
+ )
+ try:
+ self.wrapped.reset(
+ new CRankOptions(c_sort_keys,
unwrap_null_placement(null_placement), self._tiebreaker_map[tiebreaker])
+ )
+ except KeyError:
+ _raise_invalid_function_option(tiebreaker, "tiebreaker")
+
+
+class RankOptions(_RankOptions):
+ """
+ Options for the `rank` function.
+
+ Parameters
+ ----------
+ sort_keys : sequence of (name, order) tuples
Review Comment:
I have pushed a new commit with some changes. I've added a test to ensure we
can call `pc.rank()` without options and I've just applied the diff I proposed
previously. I am not entirely sure I understand the proposal around injecting a
fake ordering and what are the benefits vs the current implementation. With the
current implementation we can use the following signatures:
```
pc.rank(arr)
pc.rank(arr, options=pc.RankOptions())
pc.rank(arr, options=pc.RankOptions(tiebreaker="dense"))
pc.rank(arr, options=pc.RankOptions(null_placement="at_start"))
rank_options = pc.RankOptions(sort_keys=[("b", "ascending")],
null_placement="at_end",
tiebreaker=tiebreaker)
pc.rank(arr, options=rank_options)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
