rok commented on code in PR #13302: URL: https://github.com/apache/arrow/pull/13302#discussion_r892581372
########## cpp/src/arrow/compute/kernels/scalar_temporal_benchmark.cc: ########## @@ -214,5 +240,19 @@ BENCHMARK_TEMPLATE(BenchmarkStrptime, non_zoned)->Apply(SetArgs); BENCHMARK_TEMPLATE(BenchmarkStrptime, zoned)->Apply(SetArgs); BENCHMARK(BenchmarkAssumeTimezone)->Apply(SetArgs); +// binary temporal benchmarks Review Comment: `scalar_arithmetic_benchmark.cc` benchmarks non-temporal arrays right now. It would be useful to also benchmark for temporal zoned/nonzoned temporal types as computation would follow a different codepath for those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
