tustvold commented on code in PR #2677:
URL: https://github.com/apache/arrow-datafusion/pull/2677#discussion_r892625816
##########
datafusion/core/tests/sql/mod.rs:
##########
@@ -825,16 +825,9 @@ impl ExplainNormalizer {
// Push path as is
replacements.push((path.to_string_lossy().to_string(),
key.to_string()));
- // Push canonical version of path
- let canonical = path.canonicalize().unwrap();
- replacements.push((canonical.to_string_lossy().to_string(),
key.to_string()));
-
- if cfg!(target_family = "windows") {
- // Push URL representation of path, to handle windows
- let url = Url::from_file_path(canonical).unwrap();
- let path = url.path().strip_prefix('/').unwrap();
- replacements.push((path.to_string(), key.to_string()));
- }
+ // Push URL representation of path
Review Comment:
Standardized paths :tada:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
