wjones127 commented on code in PR #13108:
URL: https://github.com/apache/arrow/pull/13108#discussion_r892919451
##########
cpp/src/arrow/compute/exec/exec_plan.cc:
##########
@@ -46,7 +46,9 @@ namespace {
struct ExecPlanImpl : public ExecPlan {
explicit ExecPlanImpl(ExecContext* exec_context,
std::shared_ptr<const KeyValueMetadata> metadata =
NULLPTR)
- : ExecPlan(exec_context), metadata_(std::move(metadata)) {}
+ : ExecPlan(exec_context), metadata_(std::move(metadata)) {
+ span_ = arrow::internal::tracing::OTSpan();
Review Comment:
I'm not sure why, but we segfault in the first line of `StartProducing()`. I
believe this is because I am not initialized `span_` correctly. In the header
file, it's type is is the public Span class `arrow::util::tracing::Span`, but
for the macros to work it needs to be initialized as an
`arrow::internal::tracing::OTSpan` so that is has the shared_ptr field. (When
the spans are used just internally, I was able to solve this same segfault by
switching the declaration to `OTSpan`, but that won't work for the member
variables.)
Any idea what might be going wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
