waynexia opened a new pull request, #2713: URL: https://github.com/apache/arrow-datafusion/pull/2713
Signed-off-by: Ruihang Xia <[email protected]> # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> `PhysicalPlanner::create_physical_plan()` is an async function. I suppose `ExtensionPlanner::plan_extension()` should also be async (in my understanding they are the same in some aspect?). In fact I encounter a scenario that needs to call async function in `ExtensionPlanner::plan_extension()`. I'll review my use case and provide a more concrete example tomorrow. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Change `ExtensionPlanner::plan_extension()` to an async function # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Yes. `ExtensionPlanner` becomes an async trait. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
