jhorstmann commented on PR #1825: URL: https://github.com/apache/arrow-rs/pull/1825#issuecomment-1151670264
Looks good, nice improvement. Regarding the benchmarks, maybe the `Deref for ScalarBuffer` needs an explicit `#[inline]` annotation. Everything else in the hot methods, including the `to_isize`, should already get inlined, maybe the compiler decides the method is over some size threshold. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
