amol- commented on code in PR #13342:
URL: https://github.com/apache/arrow/pull/13342#discussion_r894378516
##########
python/pyarrow/ipc.pxi:
##########
@@ -399,21 +399,23 @@ cdef class MessageReader(_Weakrefable):
"instead.".format(self.__class__.__name__))
@staticmethod
- def open_stream(source):
+ def open_stream(source, use_memory_map=False):
Review Comment:
I think `user_memory_map` here is misleading for a user.
`source` can be a `PythonFile` or `NativeFile`, in such case the memory map
option won't do anything. The option is only effective if the `source` is a
string.
Given that the user can pass a `MemoryMappedFile` if they want to explicitly
use `memory_map`. I think we should remove the option and explicitly document
to use `MemoryMappedFile` as the source if you want to use memory mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
