alamb commented on code in PR #2680:
URL: https://github.com/apache/arrow-datafusion/pull/2680#discussion_r894797428


##########
datafusion/sql/src/planner.rs:
##########
@@ -2711,6 +2711,15 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_int_decimal_default() {
+        quick_test(
+            "SELECT CAST(10 AS DECIMAL)",

Review Comment:
   Can we please add a test for the other cases?
   
   * Specify only scale, use default precision: `CAST (10 AS DECIMAL(5))`
   * Error that scale is larger than precision: `CAST(10 AS DECIMAL(5, 10))` 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to