MazterQyou commented on code in PR #1836:
URL: https://github.com/apache/arrow-rs/pull/1836#discussion_r894965830
##########
arrow/src/compute/kernels/temporal.rs:
##########
@@ -389,6 +443,48 @@ mod tests {
assert_eq!(2012, b.value(2));
}
+ #[test]
+ fn test_temporal_array_date64_quarter() {
+ //1514764800000 -> 2018-01-01
+ //1566275025000 -> 2019-08-20
Review Comment:
I don't think it's worth it considering the first test is already at the
beginning of a quarter.
If you think it's a good idea to test that specifically, I could either
change the first test to April 1st, or add another date to the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
