alexandreyc commented on code in PR #13370: URL: https://github.com/apache/arrow/pull/13370#discussion_r895099393
########## cpp/examples/arrow/row_wise_conversion_example.cc: ########## @@ -97,7 +97,7 @@ arrow::Result<std::shared_ptr<arrow::Table>> VectorToColumnarTable( ARROW_RETURN_NOT_OK(id_builder.Finish(&id_array)); std::shared_ptr<arrow::Array> components_array; ARROW_RETURN_NOT_OK(components_builder.Finish(&components_array)); - // No need to invoke component_cost_builder.Finish because it is implied by + // No need to invoke component_item_cost_builder.Finish because it is implied by // the parent builder's Finish invocation. std::shared_ptr<arrow::Array> component_cost_array; ARROW_RETURN_NOT_OK(component_cost_builder.Finish(&component_cost_array)); Review Comment: No need to rename the variable. It's that the comment references the wrong variable. ########## cpp/examples/arrow/row_wise_conversion_example.cc: ########## @@ -97,7 +97,7 @@ arrow::Result<std::shared_ptr<arrow::Table>> VectorToColumnarTable( ARROW_RETURN_NOT_OK(id_builder.Finish(&id_array)); std::shared_ptr<arrow::Array> components_array; ARROW_RETURN_NOT_OK(components_builder.Finish(&components_array)); - // No need to invoke component_cost_builder.Finish because it is implied by + // No need to invoke component_item_cost_builder.Finish because it is implied by // the parent builder's Finish invocation. std::shared_ptr<arrow::Array> component_cost_array; ARROW_RETURN_NOT_OK(component_cost_builder.Finish(&component_cost_array)); Review Comment: No need to rename the variable. It's just that the comment references the wrong variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
