thinkharderdev commented on code in PR #2716:
URL: https://github.com/apache/arrow-datafusion/pull/2716#discussion_r895175300
##########
datafusion/optimizer/src/single_distinct_to_groupby.rs:
##########
@@ -250,6 +280,29 @@ mod tests {
Ok(())
}
+ #[test]
+ fn single_distinct_and_grouping_set() -> Result<()> {
Review Comment:
Ok, this optimization is a bit more complicated for grouping sets. We need
to create a separate alias for each group. For the moment I have just disabled
the optimization for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
