alamb commented on issue #131:
URL: https://github.com/apache/arrow-rs/issues/131#issuecomment-1153867528

   > In current Rust implementations, we use i128 in DecimalBuilder and 
DecimalArray APIs. To maintain consistency on Decimal related APIs, we need to 
change from i128 to Decimal128 in these APIs.
   
   
   What do you think about using generics (so the APIs are compatible).
   
   So for functions that take `i128` like
   
   ```rust
   fn decimal_thing(val: i128) {
   ...
   }
   ```
   
   Could be something like
   
   ```rust
   fn decimal_thing(val: impl Into<i128>) {
   }
   ```
   
   This may be a silly idea that won't make sense as you start implementation 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to