vibhatha commented on code in PR #13375:
URL: https://github.com/apache/arrow/pull/13375#discussion_r895853513
##########
cpp/src/arrow/engine/substrait/plan_internal.cc:
##########
@@ -92,6 +92,9 @@ Status AddExtensionSetToPlan(const ExtensionSet& ext_set,
substrait::Plan* plan)
Result<ExtensionSet> GetExtensionSetFromPlan(const substrait::Plan& plan,
const ExtensionIdRegistry*
registry) {
Review Comment:
Maybe,
```suggestion
Result<ExtensionSet> GetExtensionSetFromPlan(const substrait::Plan& plan,
const ExtensionIdRegistry*
registry = default_extension_id_registry()) {
```
Is there a specific reason why we have to explicitly assign if `NULLPTR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
