tustvold commented on code in PR #1866:
URL: https://github.com/apache/arrow-rs/pull/1866#discussion_r895931569
##########
arrow/src/buffer/mutable.rs:
##########
@@ -299,7 +296,7 @@ impl MutableBuffer {
/// assert_eq!(buffer.len(), 8) // u32 has 4 bytes
/// ```
#[inline]
- pub fn extend_from_slice<T: ToByteSlice>(&mut self, items: &[T]) {
+ pub fn extend_from_slice<T: ArrowNativeType>(&mut self, items: &[T]) {
Review Comment:
This method was potentially unsound, as ToByteSlice is not sealed and so
could theoretically be implemented for a type that is not trivially
transmutable (which the implementation of this method implicitly assumes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
