suhsteve commented on a change in pull request #8146:
URL: https://github.com/apache/arrow/pull/8146#discussion_r486665172



##########
File path: csharp/src/Apache.Arrow/Ipc/ArrowStreamWriter.cs
##########
@@ -212,6 +212,96 @@ private void CountSelfAndChildrenNodes(IArrowType type, 
ref int count)
             count++;
         }
 
+        private protected void WriteRecordBatchInternal(RecordBatch 
recordBatch)
+        {
+            // TODO: Truncate buffers with extraneous padding / unused capacity
+
+            if (!HasWrittenSchema)
+            {
+                WriteSchema(Schema);
+                HasWrittenSchema = true;
+            }
+
+            Builder.Clear();

Review comment:
       Refactored this part out.  Let me know if this was what you were 
expecting.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to