nl5887 commented on PR #67: URL: https://github.com/apache/arrow-ballista/pull/67#issuecomment-1155134040
> @nl5887 Do you have examples of panics that this fixes? Can we fix the root cause by using `Result` instead of calling `panic!` or `unimplemented!`? One of the cases this occurs, is when schemas aren't compatible. (eg in situations of an expect()). With this commit, it at least will return that task failed, instead of keeping it open. Completely agree with that the root causes should be fixed and using Result, but this fix is related to the edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
