emkornfield commented on a change in pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#discussion_r486759286



##########
File path: cpp/src/arrow/array/builder_base.h
##########
@@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder {
   virtual Status AppendNull() = 0;
   virtual Status AppendNulls(int64_t length) = 0;
 
+  virtual Status AppendEmptyValue() = 0;

Review comment:
       Yes, the change meets the spec but potentially breaks parquet writing 
for use-cases going through th builder per 
https://issues.apache.org/jira/browse/ARROW-9603?filter=-2 (which relies on the 
behavior of forcing nulls).  I would prefer not to change this behavior before 
fixing the referenced bug.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to