lidavidm commented on code in PR #13375:
URL: https://github.com/apache/arrow/pull/13375#discussion_r896962558
##########
cpp/src/arrow/engine/substrait/util.cc:
##########
@@ -68,7 +68,7 @@ class SubstraitExecutor {
compute::ExecContext exec_context)
: plan_(std::move(plan)), exec_context_(exec_context) {}
- ~SubstraitExecutor() { ARROW_CHECK_OK(this->Close()); }
+ ~SubstraitExecutor() { ARROW_UNUSED(this->Close()); }
Review Comment:
I suppose idempotent is not the right word.
I guess I can see the motivation for this behavior: we can just swallow the
error, and it won't matter to "well behaved" application since it will have
handled the error, and then we don't need to track any extra state. So I
suppose this is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
