ming535 commented on issue #2723: URL: https://github.com/apache/arrow-datafusion/issues/2723#issuecomment-1156711604
I went through the codebase and some related github issue. So it seems that we need to: 1. Support all `DataType`'s encoding/decoding including nested types such as `List`, `Struct`. 2. Go through all type of `AggregateExpr` and implement related `RowAccumulator` if it doesn't have one. 3. Benchmark the above row based aggregation and compare it with the original column one. 4. delete `create_accumulator` in `AggregateExpr` and always use `create_row_accumulator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
