alamb commented on code in PR #2729:
URL: https://github.com/apache/arrow-datafusion/pull/2729#discussion_r898457063
##########
datafusion/optimizer/src/utils.rs:
##########
@@ -276,9 +276,13 @@ pub fn rewrite_expression(expr: &Expr, expressions:
&[Expr]) -> Result<Expr> {
}
Expr::Not(_) => Ok(Expr::Not(Box::new(expressions[0].clone()))),
Expr::Negative(_) =>
Ok(Expr::Negative(Box::new(expressions[0].clone()))),
+ Expr::InList { list, negated, .. } => Ok(Expr::InList {
+ expr: Box::new(expressions[0].clone()),
+ list: list.clone(),
+ negated: *negated,
+ }),
Expr::Column(_)
| Expr::Literal(_)
- | Expr::InList { .. }
| Expr::Exists { .. }
Review Comment:
🤔 looks like `Exists` and `Subquery` may need the same treatment (not in
this PR though).... I'll file a follow on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
