vibhatha commented on code in PR #13344:
URL: https://github.com/apache/arrow/pull/13344#discussion_r899042495
##########
cpp/src/arrow/compute/api_aggregate.h:
##########
@@ -401,7 +401,7 @@ struct ARROW_EXPORT Aggregate {
std::string function;
/// options for the aggregation function
- const FunctionOptions* options;
+ std::shared_ptr<FunctionOptions> options;
Review Comment:
Good point, initially the idea was to put a `unique_ptr`, but there was a
discussion in the JIRA and finally settled for the `shared_ptr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
