andygrove commented on code in PR #2741: URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r899737401
########## benchmarks/tpch-gen.sh: ########## @@ -21,7 +21,12 @@ pushd .. . ./dev/build-set-env.sh popd -docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile . + +if [[ -z $1 ]]; then + docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION . + else + docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION --build-arg scale_factor=$1 . Review Comment: Is there a way we can just pass the scale factor as an argument in `docker run` rather than building the image differently? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
