jorgecarleitao commented on a change in pull request #8172:
URL: https://github.com/apache/arrow/pull/8172#discussion_r487307984
##########
File path: rust/datafusion/src/physical_plan/expressions.rs
##########
@@ -97,766 +104,712 @@ pub fn col(name: &str) -> Arc<dyn PhysicalExpr> {
/// SUM aggregate expression
#[derive(Debug)]
pub struct Sum {
+ name: String,
Review comment:
`AggregateExpr` has this information with them now because it allows
them to `create_accumulator` without access to the input schema. This is
helpful because, on the second pass, we need to create accumulators on the fly,
and the input_schema of the second pass is different, as it now corresponds to
the schema
`[group1, group2, agg1_state1, agg1_state2, ...]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
