waynexia commented on code in PR #1912:
URL: https://github.com/apache/arrow-rs/pull/1912#discussion_r901117043
##########
arrow/src/array/array_dictionary.rs:
##########
@@ -169,6 +169,17 @@ impl<'a, K: ArrowPrimitiveType> DictionaryArray<K> {
.iter()
.map(|key| key.map(|k| k.to_usize().expect("Dictionary index not
usize")))
}
+
+ /// Return the value of `keys` (the dictionary key) at index `i`,
+ /// cast to `usize`, `None` if the value at `i` is `NULL`.
+ pub fn key(&self, i: usize) -> Option<usize> {
+ self.keys.is_valid(i).then(|| {
+ self.keys
+ .value(i)
+ .to_usize()
+ .expect("Dictionary index not usize")
Review Comment:
For most cases this unwrap won't panic, but do we need to maintain the same
behavior with
https://github.com/apache/arrow-datafusion/blob/080c32400ddfa2d45b5bebb820184eac8fd5a03a/datafusion/common/src/scalar.rs#L342-L358
? If so the return type can either be `Result<Option<_>>` or `Option<_>`, I'm
ok with both (hard to choose...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
