vibhatha commented on code in PR #13401:
URL: https://github.com/apache/arrow/pull/13401#discussion_r901274897
##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -1173,5 +1175,168 @@ TEST(Substrait, JoinPlanInvalidKeys) {
&ext_set));
}
+TEST(Substrait, SerializeRelation) {
+#ifdef _WIN32
+ GTEST_SKIP() << "ARROW-16392: Substrait File URI not supported for Windows";
+#else
+ ExtensionSet ext_set;
+ auto dummy_schema = schema({field("f1", int32()), field("f2", int32())});
+ // creating a dummy dataset using a dummy table
+ auto format = std::make_shared<arrow::dataset::ParquetFileFormat>();
+ auto filesystem = std::make_shared<fs::LocalFileSystem>();
+
+ std::vector<fs::FileInfo> files;
+ const std::vector<std::string> f_paths = {"/tmp/data1.parquet",
"/tmp/data2.parquet"};
+
+ for (const auto& f_path : f_paths) {
+ ASSERT_OK_AND_ASSIGN(auto f_file, filesystem->GetFileInfo(f_path));
+ files.push_back(std::move(f_file));
+ }
+
+ ASSERT_OK_AND_ASSIGN(auto ds_factory,
dataset::FileSystemDatasetFactory::Make(
+ std::move(filesystem),
std::move(files),
+ std::move(format), {}));
+ ASSERT_OK_AND_ASSIGN(auto dataset, ds_factory->Finish(dummy_schema));
+
+ auto options = std::make_shared<dataset::ScanOptions>();
+ options->projection = compute::project({}, {});
+ auto scan_node_options = dataset::ScanNodeOptions{dataset, options};
+
+ auto scan_declaration = compute::Declaration({"scan", scan_node_options});
+
+ ASSERT_OK_AND_ASSIGN(auto serialized_rel,
+ SerializeRelation(scan_declaration, &ext_set));
+ ASSERT_OK_AND_ASSIGN(auto deserialized_decl,
+ DeserializeRelation(*serialized_rel, ext_set));
+
+ auto dataset_comparator = [](std::shared_ptr<dataset::Dataset> ds_lhs,
Review Comment:
cc @westonpace
Would it be better if we add a `Equals` method to `FileSystemDataset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
