alamb commented on pull request #8161: URL: https://github.com/apache/arrow/pull/8161#issuecomment-691468844
Thank you @jhorstmann > My only concern is that this could cause tests to fail if they use local timestamps and are then run on machines with different time zones. This can probably only be solved with careful review, and by hopefully having the ci run with different time zones than your local machines. Yes -- I agree. I have been bitten by this kind of issue in the past. The other fun one was when the local timezone offset changes due to daylight savings time. The other work around is to use a timestamp with an explicit timezone offset (eg ending in `Z`). >One (not directly related) issue I noticed while trying this out, is that the local patterns seem to require the millisecond part, while for utc timestamps with "Z" they are optional: This is a good find and I will fix that in a subsequent PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
