jorgecarleitao commented on a change in pull request #8172:
URL: https://github.com/apache/arrow/pull/8172#discussion_r487403512
##########
File path: rust/arrow/src/compute/kernels/aggregate.rs
##########
@@ -19,9 +19,42 @@
use std::ops::Add;
-use crate::array::{Array, PrimitiveArray};
+use crate::array::{Array, LargeStringArray, PrimitiveArray, StringArray};
use crate::datatypes::ArrowNumericType;
+/// Helper macro to perform min/max of strings
+macro_rules! min_max_string_helper {
+ ($array:expr, $cmp:tt) => {{
+ let null_count = $array.null_count();
+
+ if null_count == $array.len() {
+ return None
+ }
+ let mut n = "";
+ let mut has_value = false;
+ let data = $array.data();
+
+ if null_count == 0 {
Review comment:
yes. Generally, operations on non-null fields are faster because there
isn't an unpredictable branch on the loop. This check removes that
unpredictable branch altogether when there are no nulls.
We could probably still get some more juice by using some of the vertical
operations supported by packed_simd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
