andygrove commented on code in PR #2750:
URL: https://github.com/apache/arrow-datafusion/pull/2750#discussion_r903140029
##########
datafusion/sql/src/planner.rs:
##########
@@ -784,6 +784,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let filter_expr = self.sql_to_rex(predicate_expr,
&join_schema, ctes)?;
+ // reduce outer joins
+ let plans = reduce_outer_joins(plans, &filter_expr)?;
Review Comment:
This seems like it should be implemented as an optimization rule rather than
in the SQL query planner and this would mean that we would get the same
optimizations regardless of whether the query was created from SQL or from the
DataFrame API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
