paleolimbot commented on code in PR #13150:
URL: https://github.com/apache/arrow/pull/13150#discussion_r903188788


##########
r/R/query-engine.R:
##########
@@ -259,6 +221,49 @@ ExecPlan <- R6Class("ExecPlan",
       )
     },
     Stop = function() ExecPlan_StopProducing(self)
+  ),
+  private = list(
+    .config_aggregation = function(node, data, grouped, group_vars) {
+      # Project to include just the data required for each aggregation,

Review Comment:
   I think the issue is with `list[node, data] <- ...`, which looks off to me.
   
   ``` r
   list[1, 2] <- "something"
   #> Error in list[1, 2] <- "something": object of type 'builtin' is not 
subsettable
   ```
   
   Maybe you want `config <- .config_aggregation(...)` then `node <- 
config$node` and `.data <- config$data`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to