vibhatha commented on code in PR #13412:
URL: https://github.com/apache/arrow/pull/13412#discussion_r903323137
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -383,6 +401,14 @@ Result<Datum> CumulativeSum(const Datum& values, const
CumulativeSumOptions& opt
return CallFunction(func_name, {Datum(values)}, &options, ctx);
}
+Result<Datum> CumulativeProduct(const Datum& values,
+ const CumulativeProductOptions& options,
+ ExecContext* ctx) {
+ auto func_name =
+ (options.check_overflow) ? "cumulative_product_checked" :
"cumulative_product";
+ return CallFunction(func_name, {Datum(values)}, &options, ctx);
Review Comment:
May be
```suggestion
return CallFunction(
options.check_overflow ? "cumulative_sum_checked" : "cumulative_sum",
{Datum(values)}, &options, ctx);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
