mrob95 opened a new pull request, #2765:
URL: https://github.com/apache/arrow-datafusion/pull/2765
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #2736.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Looking at the expressions mentioned in #2725, I think the only one that
needs fixing is `Expr::InSubquery`. `Exists` and `ScalarSubquery` both have
subqueries but not subexpressions, and it looks like subqueries are currently
treated as completely separate plans for the purposes of optimisation. I'm new
to working on query engines (and rust, for that matter!) though so may be
misinterpreting this.
I've modified `rewrite_expression` so `InSubquery` exprs use the
subexpression passed in `expressions` rather than just returning a clone, and
added a pushdown test with an `InSubquery` predicate which uses an aliased
column.
Additionally, I noticed while I was creating the test case that `InSubquery`
filters were not being pushed down at all. This was because the subexpressions
of `InSubquery` were not being visited by `ExpressionVisitor`, so the column in
`InSubquery` predicates was not found. Fixed with a simple modification to
`expr_visitor.rs`. The test case I added covers this as well.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
