viirya commented on code in PR #1922:
URL: https://github.com/apache/arrow-rs/pull/1922#discussion_r904175802
##########
arrow/src/compute/kernels/cast.rs:
##########
@@ -72,9 +72,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
// cast one decimal type to another decimal type
(Decimal(_, _), Decimal(_, _)) => true,
// signed numeric to decimal
- (Int8 | Int16 | Int32 | Int64 | Float32 | Float64, Decimal(_, _)) |
+ (Null|Int8 | Int16 | Int32 | Int64 | Float32 | Float64, Decimal(_, _))
|
// decimal to signed numeric
- (Decimal(_, _), Int8 | Int16 | Int32 | Int64 | Float32 | Float64)
+ (Decimal(_, _), Null| Int8 | Int16 | Int32 | Int64 | Float32 | Float64)
Review Comment:
I think currently Cast kernel is not correct on casting to NullType
behavior. It is not following C++ implementation. I issued
#https://github.com/apache/arrow-rs/issues/1923 to follow it. I may take some
time to propose a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
