wjones127 commented on code in PR #13404:
URL: https://github.com/apache/arrow/pull/13404#discussion_r904397786
##########
r/configure.win:
##########
@@ -104,6 +105,10 @@ function configure_dev() {
PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_S3"
fi
+ if [ $(cmake_option ARROW_GCS) -eq 1 ]; then
+ PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_GCS -DCURL_STATICLIB"
+ fi
Review Comment:
I think we should be able to let pkg-config handle adding the flags and
libraries for libcurl:
```suggestion
if [ $(cmake_option ARROW_GCS) -eq 1 ]; then
PKG_CFLAGS="$PKG_CFLAGS -DARROW_R_WITH_GCS"
PKG_CONFIG_PACKAGES="$PKG_CONFIG_PACKAGES libcurl"
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
