AssHero commented on code in PR #2721:
URL: https://github.com/apache/arrow-datafusion/pull/2721#discussion_r904444409
##########
datafusion/core/src/physical_plan/hash_join.rs:
##########
@@ -947,6 +951,58 @@ macro_rules! equal_rows_elem {
}};
}
+macro_rules! equal_rows_elem_with_string_dict {
+ ($key_array_type:ident, $l: ident, $r: ident, $left: ident, $right: ident,
$null_equals_null: ident) => {{
+ let left_array: &DictionaryArray<$key_array_type> =
+ as_dictionary_array::<$key_array_type>($l);
+ let right_array: &DictionaryArray<$key_array_type> =
+ as_dictionary_array::<$key_array_type>($r);
+
+ let (left_values, left_values_index) = {
+ let keys_col = left_array.keys();
+ if keys_col.is_valid($left) {
+ let values_index =
keys_col.value($left).to_usize().ok_or_else(|| {
+ DataFusionError::Internal(format!(
+ "Can not convert index to usize in dictionary of type
creating group by value {:?}",
+ keys_col.data_type()
+ ))
+ });
+
+ match values_index {
+ Ok(index) => (as_string_array(left_array.values()),
Some(index)),
+ _ => (as_string_array(left_array.values()), None)
Review Comment:
Thanks！
> Thanks again @AssHero -- let me know if you would like help filing the
issue for the strange behavior we were seeing with `c5`
yes, i'll trace the issue and try to solve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
