JabariBooker commented on code in PR #13109:
URL: https://github.com/apache/arrow/pull/13109#discussion_r905306348
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -1702,13 +1702,33 @@ def test_logical():
def test_cast():
+ arr = pa.array([1, 2, 3, 4], type='int64')
+ options = pc.CastOptions(pa.int8())
+
+ with pytest.raises(ValueError):
+ pc.cast(arr, target_type=None)
+
+ with pytest.raises(ValueError):
+ pc.cast(arr, 'int32', safe=True, options=options)
+
+ with pytest.raises(ValueError):
+ pc.cast(arr, 'int32', safe=False, options=options)
+
+ assert pc.cast(arr, 'int8', options=options) == pa.array(
+ [1, 2, 3, 4], type='int8')
+
arr = pa.array([2 ** 63 - 1], type='int64')
+ allow_overflow_options = pc.CastOptions(
+ pa.int32(), allow_int_overflow=True)
with pytest.raises(pa.ArrowInvalid):
pc.cast(arr, 'int32')
assert pc.cast(arr, 'int32', safe=False) == pa.array([-1], type='int32')
+ assert pc.cast(arr, 'int32', options=allow_overflow_options) == pa.array(
+ [-1], type='int32')
Review Comment:
Agreed. As it is now, you effectively pass the "to" type twice and error is
returned if your value for `type` doesn't match that of `options.target_type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
