alamb commented on PR #1914: URL: https://github.com/apache/arrow-rs/pull/1914#issuecomment-1164788464
Thanks @viirya and @liukun4515 for the careful review I think this look good enough to go for me -- given @liukun4515 approved this PR I will assume he is ok with merging as is (and we can improve it more in future PRs). I don't quite follow all the discussion on https://github.com/apache/arrow-rs/pull/1914#discussion_r904803039 so I don't know if there is any outstanding issues there we should be tracking or not 🤔 Let me know if it would help if I filed follow on tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
