martin-g commented on code in PR #1937:
URL: https://github.com/apache/arrow-rs/pull/1937#discussion_r906004594
##########
parquet/src/arrow/schema.rs:
##########
@@ -300,10 +300,15 @@ fn arrow_to_parquet_type(field: &Field) -> Result<Type> {
.with_repetition(repetition)
.build()
}
- DataType::Timestamp(time_unit, _) => {
+ DataType::Timestamp(time_unit, tz) => {
+ let is_utc = tz
+ .as_ref()
+ .map(|tz| tz == "UTC" || tz == "+00:00" || tz == "-00:00")
Review Comment:
Technically GMT is the timezone -
https://www.timeanddate.com/time/gmt-utc-time.html
Should `GMT` be added in the checks too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
