jhorstmann opened a new pull request, #1945:
URL: https://github.com/apache/arrow-rs/pull/1945
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #1944.
# Rationale for this change
`Send + Sync` were previously implemented for `Buffer` which probably was
not sound in case the underlying `Allocation` was not also `Send + Sync`.
<!---
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
- `Allocation` trait requires `Send + Sync`
- `Bytes` implements `Send + Sync` which should be fine since it only
contains a `NonNull` pointer in addition to the allocation
- `Buffer` is then automatically `Send + Sync`
- `FFI_ArrowArray` now has to implement `Send + Sync`. This requirement was
previously hidden by the unsafe impl on `Buffer`, even before the introduction
of the `Allocation` abstraction in #1494
<!---
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
This could be a breaking change for users of the `Allocation` trait, but
those usages would have been unsound before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]