paleolimbot commented on code in PR #13397:
URL: https://github.com/apache/arrow/pull/13397#discussion_r906622514


##########
r/R/query-engine.R:
##########
@@ -190,7 +190,7 @@ ExecPlan <- R6Class("ExecPlan",
       }
       node
     },
-    Run = function(node) {
+    Run = function(node, as_table = FALSE) {

Review Comment:
   In order for the user-defined function call from the query engine into R to 
work, the entire evaluation has to occur during one R call into C++ 
(specifically, within one call to `RunWithCapturedR()`). This is why some 
changes in the this file and compute-exec.cpp were needed...it's not all that 
clean feeling to me but I don't know there's a better way to do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to