kou commented on PR #12914:
URL: https://github.com/apache/arrow/pull/12914#issuecomment-1166353275

   > I have added an install script for azurite but this seems to fail with a 
permission denied 
error([log](https://github.com/apache/arrow/runs/7055116184?check_suite_focus=true)),
 do we need to add this script somewhere else as well?
   
   `chmod +x ci/scripts/install_azurite.sh && git add 
ci/scripts/install_azurite.sh && git commit` will resolve it.
   
   > Also, the windows build fails with a linker 
error([log](https://github.com/apache/arrow/runs/7055116275?check_suite_focus=true)),
 Are we not supposed to use `azurefs_objlib` with `WIN32`? Ref: 
https://github.com/apache/arrow/blob/master/cpp/cmake_modules/BuildUtils.cmake#L205
   
   This isn't related to object library. It's caused by building Azure SDK for 
C++. It's a problem of Azure SDK for C++. 
https://github.com/Azure/azure-sdk-for-cpp/blob/80cf3d09fdebbf4a427a0a8b89d054250bb48ec9/sdk/storage/azure-storage-common/CMakeLists.txt#L98
 should be executed only in `if(MSVC)` not `if(WIN32)`. Could you report this 
to Azure SDK for C++?
   (Note that we should not change 
https://github.com/Azure/azure-sdk-for-cpp/blob/80cf3d09fdebbf4a427a0a8b89d054250bb48ec9/sdk/storage/azure-storage-common/CMakeLists.txt#L95
 to `if(MSVC)` because there is one more statement: 
https://github.com/Azure/azure-sdk-for-cpp/blob/80cf3d09fdebbf4a427a0a8b89d054250bb48ec9/sdk/storage/azure-storage-common/CMakeLists.txt#L96
 )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to