tustvold commented on code in PR #1947:
URL: https://github.com/apache/arrow-rs/pull/1947#discussion_r907214486
##########
parquet/src/file/metadata.rs:
##########
@@ -611,6 +611,29 @@ impl ColumnChunkMetaData {
encrypted_column_metadata: None,
}
}
+
+ /// Method to convert to Thrift `ColumnMetaData`
+ pub fn to_column_metadata_thrift(&self) -> ColumnMetaData {
Review Comment:
Could we change `to_thrift` above to use this method
##########
parquet/src/file/writer.rs:
##########
@@ -435,12 +435,15 @@ impl<'a, W: Write> SerializedPageWriter<'a, W> {
Ok(self.sink.bytes_written() - start_pos)
}
- /// Serializes column chunk into Thrift.
+ /// Serializes column metadata into Thrift.
/// Returns Ok() if there are not errors serializing and writing data into
the sink.
#[inline]
- fn serialize_column_chunk(&mut self, chunk: parquet::ColumnChunk) ->
Result<()> {
+ fn serialize_column_chunk(
Review Comment:
Could we just remove this method and move its content into write_metadata?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
