lidavidm commented on code in PR #13109:
URL: https://github.com/apache/arrow/pull/13109#discussion_r907365385
##########
python/pyarrow/compute.py:
##########
@@ -367,12 +369,18 @@ def cast(arr, target_type, safe=True):
-------
casted : Array
"""
- if target_type is None:
- raise ValueError("Cast target type must not be None")
- if safe:
- options = CastOptions.safe(target_type)
- else:
- options = CastOptions.unsafe(target_type)
+ safe_vars_passed = (safe is not None) or (target_type is not None)
+
+ if safe_vars_passed and (options is not None):
+ raise ValueError("Must either pass values for 'target_type' and 'safe'"
+ " or pass a value for 'options'")
+
+ if options is None:
+ pa.types.lib.ensure_type(target_type)
Review Comment:
```suggestion
type = pa.types.lib.ensure_type(target_type)
```
##########
python/pyarrow/_compute.pyx:
##########
@@ -2198,7 +2198,18 @@ cdef class Expression(_Weakrefable):
-------
cast : Expression
"""
- options = CastOptions.safe(ensure_type(type))
+ safe_vars_passed = (safe is not None) or (type is not None)
+
+ if safe_vars_passed and (options is not None):
+ raise ValueError("Must either pass values for 'type' and 'safe' or
pass a "
+ "value for 'options'")
+
+ if options is None:
+ ensure_type(type, allow_none=False)
Review Comment:
```suggestion
type = ensure_type(type, allow_none=False)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
