westonpace commented on code in PR #13375:
URL: https://github.com/apache/arrow/pull/13375#discussion_r907788223
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -229,6 +229,20 @@ class ARROW_EXPORT SinkNodeConsumer {
virtual Future<> Finish() = 0;
};
+class ARROW_EXPORT NullSinkNodeConsumer : public SinkNodeConsumer {
Review Comment:
True, but the method on line 132 is, itself, never used that I can tell.
Also, the docs for that method mention plans with just writes which seems
incorrect since those plans would use `WriteNodeFactory`. If we're going to
add new public methods then it should be clear the situation in which the are
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
