liukun4515 commented on code in PR #1935: URL: https://github.com/apache/arrow-rs/pull/1935#discussion_r908066758
########## parquet/src/file/writer.rs: ########## @@ -85,7 +86,7 @@ pub type OnCloseColumnChunk<'a> = /// Callback invoked on closing a row group, arguments are: /// /// - the row group metadata -pub type OnCloseRowGroup<'a> = Box<dyn FnOnce(RowGroupMetaDataPtr) -> Result<()> + 'a>; +pub type OnCloseRowGroup<'a> = Box<dyn FnOnce(RowGroupMetaData) -> Result<()> + 'a>; Review Comment: change from the ptr to the owner of the data. We need to change/edit the columnchunk/column_metadata field after write the column/offset index to the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
