rok commented on code in PR #12154:
URL: https://github.com/apache/arrow/pull/12154#discussion_r908332144
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -211,9 +212,15 @@ register_bindings_datetime_components <- function() {
hour <- Expression$create("hour", x)
hour < 12
})
+
register_binding("pm", function(x) {
!call_binding("am", x)
})
+
+ register_binding("leap_year", function(date) {
+ Expression$create("is_leap_year", date)
+ })
+
Review Comment:
I could very well be very wrong, but I think this is handled by
[expression.R](https://github.com/apache/arrow/blob/master/r/R/expression.R#L78)
and can removed completely. (Bad rebase, mea culpa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
