pitrou commented on code in PR #13394:
URL: https://github.com/apache/arrow/pull/13394#discussion_r908529139
##########
cpp/src/arrow/csv/writer.cc:
##########
@@ -59,6 +59,18 @@ namespace csv {
namespace {
+// Copy delimiter or end-of-line chars. Though configurable,
+// delimiter is always one char, end-of-line is often at most two chars.
+void copy_endchars(char* dest, const char* src, size_t size) {
Review Comment:
Nit: `CopyEndChars`?
##########
cpp/src/arrow/csv/writer.cc:
##########
@@ -59,6 +59,18 @@ namespace csv {
namespace {
+// Copy delimiter or end-of-line chars. Though configurable,
+// delimiter is always one char, end-of-line is often at most two chars.
Review Comment:
Explain that this is for performance, stating the reason doing things this
way is faster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
